Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSpec parameter list mismatch between Terraform and Pulumi #239

Open
alexsavio opened this issue Jun 1, 2021 · 1 comment
Open

AppSpec parameter list mismatch between Terraform and Pulumi #239

alexsavio opened this issue Jun 1, 2021 · 1 comment
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@alexsavio
Copy link

I was using the App object in Python, and I found a mismatch of information in the AppSpecArgs class definition. It said that the domains argument was deprecated and replaced by the domain argument. However there was no domain argument.

I digged into the code and if I am not mistaken the domain argument is missing?

https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/digitalocean/app_spec.go#L27

https://github.com/pulumi/pulumi-digitalocean/blob/v4.3.1/provider/cmd/pulumi-resource-digitalocean/schema.json#L79
@alexsavio alexsavio added the kind/bug Some behavior is incorrect or out of spec label Jun 1, 2021
@lukehoban
Copy link
Member

It looks like we are mapping this to domainNames. We likely need to update the deprecation message to align with this?

https://github.com/pulumi/pulumi-digitalocean/blob/master/provider/resources.go#L263-L276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukehoban @stack72 @alexsavio