Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudRun: wait until revision is deployed #105

Closed
mszewczyk-ipwt opened this issue Jun 1, 2021 · 3 comments
Closed

CloudRun: wait until revision is deployed #105

mszewczyk-ipwt opened this issue Jun 1, 2021 · 3 comments
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed service/cloudrun

Comments

@mszewczyk-ipwt
Copy link

mszewczyk-ipwt commented Jun 1, 2021

Currently If a pulumi_google_native.run.v1.Service is declared and pulumi is updating resources then the update is finished before revision is up and traffic is rerouted. This can result in false information about CloudRun service updated while on the GCP side it can still fail, because the service is not up and running.

Example timeline with failed service:

  1. Begin update
  2. Pulumi is applying revision
  3. GCP is starting to apply revision
  4. Pulumi has finished applying revision
  5. Pulumi has finished update - exit code 0
  6. GCP is rolling new revision
  7. GCP has failed to rollout the revision

Finally Pulumi has no information that revision has failed to update.

If there was a way to declare the provider to wait until the traffic is rerouted, then the Pulumi would have the information about failed deployment.

@mszewczyk-ipwt mszewczyk-ipwt added the kind/enhancement Improvements or new features label Jun 1, 2021
@mikhailshilkov
Copy link
Member

Thank you for reporting! I think this has the same cause as #35

@mikhailshilkov mikhailshilkov added kind/bug Some behavior is incorrect or out of spec and removed kind/enhancement Improvements or new features labels Jun 1, 2021
@steren
Copy link

steren commented Jun 7, 2021

It is expected for clients to fetch the status of the Cloud Run revision deployment by polling the status field of the Service object.

@viveklak viveklak added the resolution/fixed This issue was fixed label May 25, 2022
@viveklak
Copy link
Contributor

Fixed in #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed service/cloudrun
Projects
None yet
Development

No branches or pull requests

4 participants