Port Output -versioned function invokes

[t0yv0]

Hello!

• Vote on this issue by adding a 👍 reaction
• If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently invoking a function accepts plain arguments and returns a CompleteableFuture. We instead want it to accept builders that overload T and Output<T> in the arguments, and returns an Output<Result> as the result.

For an example illustrating the design consider this snippet from azure template. It is now possible to pass Output values to invokes directly:

Design

    private static Output<String> getStorageAccountPrimaryKey(Output<String> resourceGroupName,
                                                              Output<String> accountName) {
       return StorageFunctions.listStorageAccountKeys(ListStorageAccountKeysArgs.builder()
                                                       .resourceGroupName(resourceGroupName)
                                                       .accountName(accountName)
                                                       .build())
            .applyValue(r -> r.keys().get(0).value())
            .asSecret();
    }

Before the change one had to manually await the Output args and project the resulting CompletableFuture to an Output.

    private static Output<String> getStorageAccountPrimaryKey(Output<String> resourceGroupName,
                                                              Output<String> accountName) {
        return Output.tuple(resourceGroupName, accountName).apply(tuple -> {
            var actualResourceGroupName = tuple.t1;
            var actualAccountName = tuple.t2;
            var invokeResult = StorageFunctions.listStorageAccountKeys(ListStorageAccountKeysArgs.builder()
                    .resourceGroupName(actualResourceGroupName)
                    .accountName(actualAccountName)
                    .build(), InvokeOptions.Empty);
            return Output.of(invokeResult)
                    .applyValue(r -> r.keys().get(0).value())
                    .asSecret();
        });

Breaking Changes

When Java SDKs for providers such as azure-native update to the version of codegen implementing this feature, it will be a breaking change. To upgrade your code, you have two options:

1. rewrite the code to use the new form; note for example that StorageFunctions.listStorageAccountKeys returns an Output instead of a CompletableFuture, and ListStorageAccountKeysArgs now accepts Output values.

2. rewrite the code that uses the old form; it is now renamed with a Plain suffix. So for our example, you could use StorageFunctions.listStorageAccountKeysPlain that returns a CompletableFuture as before.

Follow up

• Output-versioned function invoke fails to preview #670
• Output-versioned function invokes follow up #679

Affected area/feature

[t0yv0]

Not in preview CC @mikhailshilkov

[t0yv0]

TBD @dixler pre-plan how this looks like so plain Function calls don't grab names we want to use for Output versioned calls that we want to make "easier" or "more default".

[t0yv0]

NOTE: when doing this, also take care to update these functions that are used in docs generation:

func (d DocLanguageHelper) GetFunctionName(modName string, f *schema.Function) string {
	return tokenToFunctionName(f.Token)
}

func (d DocLanguageHelper) GetResourceFunctionResultName(modName string, f *schema.Function) string {
	return tokenToFunctionResultClassName(f.Token).String()
}

[dixler]

stepping back from this. seems a little more involved and I have to put together a demo and apply can workaround this.