Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI setup not ideal for community PRs #557

Closed
Tracked by #598
t0yv0 opened this issue May 5, 2022 · 2 comments
Closed
Tracked by #598

CI setup not ideal for community PRs #557

t0yv0 opened this issue May 5, 2022 · 2 comments
Assignees
@t0yv0
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.73

Comments

@t0yv0
Copy link
Member

t0yv0 commented May 5, 2022

What happened?

It turns out we rely on GitHub packages to communicate intermediate Java build artifacts between build phases. This is not great for community fork PRs - those do not get the GITHUB token secret divulged, making the CI verification fail.

Example: #550

Steps to reproduce

Open a PR from a forked repo.

Expected Behavior

CI verifies changes for merge-ability.

Actual Behavior

CI fails.

Versions used

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added the kind/bug Some behavior is incorrect or out of spec label May 5, 2022
@t0yv0 t0yv0 mentioned this issue May 5, 2022
Closed
3 tasks
@mikhailshilkov mikhailshilkov mentioned this issue May 17, 2022
Open
40 tasks
@t0yv0 t0yv0 self-assigned this May 24, 2022
@mikhailshilkov mikhailshilkov added this to the 0.73 milestone May 24, 2022
@t0yv0 t0yv0 mentioned this issue May 27, 2022
Merged
3 tasks
@t0yv0
Copy link
Member Author

t0yv0 commented May 27, 2022 •
edited
Loading

Adopted /run-acceptance-tests workflow from pulumi/pulumi - the community PR now succeeds on a subset of tests, then maintainer can run /run-acceptance-tests for a full set (or merge and have main branch run the full set of tests).

@t0yv0 t0yv0 closed this as completed May 27, 2022
@pulumi-bot pulumi-bot reopened this May 27, 2022
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: resolution/

@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label May 27, 2022
@t0yv0 t0yv0 closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.73
Development

No branches or pull requests
3 participants
@t0yv0 @mikhailshilkov @pulumi-bot