Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS env does not work #1150

Closed
ncsibra opened this issue May 29, 2020 · 2 comments · Fixed by #1189
Closed

PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS env does not work #1150

ncsibra opened this issue May 29, 2020 · 2 comments · Fixed by #1189
Assignees
Milestone

Comments

@ncsibra
Copy link

ncsibra commented May 29, 2020

Problem description

Based on this code: https://github.com/pulumi/pulumi-kubernetes/blob/v2.2.2/provider/pkg/provider/provider.go#L395
PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS=true should suppress the deprecation warnings, but it doesn't.

➜  dliver (pulumi2) ✗ PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS=true pulumi preview 
Previewing update (dlv-prod):
     Type                 Name             Plan     Info
     pulumi:pulumi:Stack  dliver-dlv-prod           16 warnings
 
Diagnostics:
  pulumi:pulumi:Stack (dliver-dlv-prod):
    warning: LoadBalancer is deprecated: aws.elasticloadbalancingv2.LoadBalancer has been deprecated in favor of aws.lb.LoadBalancer
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: LoadBalancer is deprecated: aws.elasticloadbalancingv2.LoadBalancer has been deprecated in favor of aws.lb.LoadBalancer
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener
    warning: TargetGroup is deprecated: aws.elasticloadbalancingv2.TargetGroup has been deprecated in favor of aws.lb.TargetGroup
    warning: Listener is deprecated: aws.elasticloadbalancingv2.Listener has been deprecated in favor of aws.lb.Listener

Tried with PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS="true" pulumi preview and PULUMI_K8S_SUPPRESS_DEPRECATION_WARNINGS="true" pulumi preview none of them works.

Versions

➜  pulumi (pulumi2) ✗ pulumi version                     
v2.3.0
➜  pulumi (pulumi2) ✗ pulumi plugin ls | grep kubernetes
kubernetes  resource  2.2.2    53 MB   n/a        52 minutes ago
kubernetes  resource  1.6.0    50 MB   n/a        1 month ago
kubernetes  resource  1.5.6    50 MB   n/a        2 months ago
kubernetes  resource  1.4.3    50 MB   n/a        4 months ago
➜  pulumi (pulumi2) ✗ yarn list --pattern "@pulumi"                                 
yarn list v1.22.0
├─ @pulumi/aws@2.6.1
├─ @pulumi/cloudflare@2.3.1
├─ @pulumi/kubernetes@2.2.2
├─ @pulumi/pulumi@2.3.0
├─ @pulumi/query@0.3.0
├─ @pulumi/random@2.1.2
├─ @pulumi/tls@2.1.2
└─ @pulumi/vault@2.2.0
@lblackstone
Copy link
Member

Figured out what the problem is here. The SDKs are now generated from a different codegen library, and it's adding these warnings directly into the SDKs.

https://github.com/pulumi/pulumi-aws/blob/c672e225a765b11b07ea23e7b1b411483d7f38da/sdk/nodejs/elasticloadbalancingv2/loadBalancer.ts#L203

@lblackstone
Copy link
Member

The plan here is to remove the log statements from the SDKs, and let the k8s provider handle this like before.

@lblackstone lblackstone removed their assignment Jun 16, 2020
@leezen leezen added this to the current milestone Jun 23, 2020
@lblackstone lblackstone self-assigned this Jul 1, 2020
@leezen leezen modified the milestones: current, 0.39 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants