Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/nodejs] YAML support broken with v3.6.0 codegen #1645

Closed
lblackstone opened this issue Jul 1, 2021 · 0 comments · Fixed by #1651
Closed

[sdk/nodejs] YAML support broken with v3.6.0 codegen #1645

lblackstone opened this issue Jul 1, 2021 · 0 comments · Fixed by #1651
Assignees
Labels
emergent An issue that was added to the current milestone after planning kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@lblackstone
Copy link
Member

lblackstone commented Jul 1, 2021

The NodeJS codegen has changed all of the getResourceProperty methods and broken a test. The change is from https://github.com/pulumi/pulumi/blame/2781cf03fee77ea09286d442ffe3a01e6823322c/pkg/codegen/nodejs/gen.go#L1878 in pulumi/pulumi#7059 and results in | undefined being added to all the types.

I tracked this down to the LanguageResources method in the codegen, which isn't accounting for the Language metadata requiredOutputs setting.

For example, the v1:Service type has the following metadata in the schema which is ignored in the LanguageResources used to generate the YAML overlay:

            "language": {
                "nodejs": {
                    "requiredOutputs": [
                        "apiVersion",
                        "kind",
                        "metadata",
                        "spec",
                        "status"
                    ]
                }
            }

Originally posted by @lblackstone in #1640 (comment)

@lblackstone lblackstone self-assigned this Jul 1, 2021
@lblackstone lblackstone added emergent An issue that was added to the current milestone after planning kind/bug Some behavior is incorrect or out of spec labels Jul 1, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergent An issue that was added to the current milestone after planning kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants