Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm Release] regression in 3.18.1 - keyring diff on updates #1959

Closed
viveklak opened this issue Apr 6, 2022 · 1 comment · Fixed by #1961
Closed

[Helm Release] regression in 3.18.1 - keyring diff on updates #1959

viveklak opened this issue Apr 6, 2022 · 1 comment · Fixed by #1961
Assignees
@viveklak
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@viveklak
Copy link
Contributor

viveklak commented Apr 6, 2022

@viveklak the fix for this issue seems to have been regressed by the fix for #1953 released in v3.18.1.

I'm not importing helm releases but pulumi update now has the following diffs when I switch between windows and linux:

 ~  kubernetes:helm.sh/v3:Release ack-iam-controller update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release ack-s3-controller update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release appmesh-controller update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release aws-ebs-csi-driver update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release aws-efs-csi-driver update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release aws-load-balancer-controller update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release cert-manager update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release cluster-autoscaler update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release external-dns update [diff: ~keyring]
 ~  kubernetes:helm.sh/v3:Release fluent-bit update [diff: ~keyring]

Originally posted by @gitfool in #1825 (comment)
@viveklak viveklak self-assigned this Apr 6, 2022
@viveklak viveklak added the p1 A bug severe enough to be the next item assigned to an engineer label Apr 6, 2022
@viveklak viveklak mentioned this issue Apr 6, 2022
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 7, 2022
@pulumi-bot pulumi-bot reopened this Apr 7, 2022
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@viveklak viveklak added the kind/bug Some behavior is incorrect or out of spec label Apr 7, 2022
@viveklak viveklak closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viveklak viveklak

Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only add keyring default value when verification is turned on pulumi/pulumi-kubernetes
2 participants
@viveklak @pulumi-bot