Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeploymentPatch should not require .spec.template.metadata.name #2115

Closed
Iced-Sun opened this issue Aug 4, 2022 · 1 comment 路 Fixed by #2126
Closed

DeploymentPatch should not require .spec.template.metadata.name #2115

Iced-Sun opened this issue Aug 4, 2022 · 1 comment 路 Fixed by #2126
Assignees
@lblackstone
Labels
area/server-side-apply kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.76

Comments

@Iced-Sun
Copy link
Contributor

Iced-Sun commented Aug 4, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

As stated in the title, .spec.template.metadata.name is required if .spec.template.metadata is presented in DeploymentPatch (as wel as StatefullSetPatch, etc.), but it shouldn't.

Affected area/feature
@Iced-Sun Iced-Sun added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 4, 2022
@stack72 stack72 removed the needs-triage Needs attention from the triage team label Aug 5, 2022
@lblackstone lblackstone added this to the 0.76 milestone Aug 9, 2022
@lblackstone
Copy link
Member

Thanks for reporting this. I overlooked the fact that the ObjectMetaPatch type is reused in the nested template types, so that's why it is currently marked as required. I'm investigating options for fixing this now.

@lblackstone lblackstone mentioned this issue Aug 9, 2022
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
area/server-side-apply kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.76
Development

Successfully merging a pull request may close this issue.

Change .metadata.name to optional for all Patch resources pulumi/pulumi-kubernetes
4 participants
@stack72 @Iced-Sun @lblackstone @pulumi-bot