Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --dry-run=server for Helm charts #2766

Open
Tracked by #2823
kwohlfahrt opened this issue Jan 23, 2024 · 1 comment
Open
Tracked by #2823

Support --dry-run=server for Helm charts #2766

kwohlfahrt opened this issue Jan 23, 2024 · 1 comment
Labels
area/helm kind/enhancement Improvements or new features

Comments

@kwohlfahrt
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Trying to install the "GitHub Actions Scale Set" Helm chart with Pulumi fails with the following error:

    error: failed to create chart from template: execution error at (gha-runner-scale-set/templates/manager_role_binding.yaml:17:11): No gha-rs-controller deployment found using label (app.kubernetes.io/part-of=gha-rs-controller). Consider setting controllerServiceAccount.name in values.yaml to be explicit if you think the discovery is wrong.

This reproduces with the Helm CLI, when using --dry-run=client (or just --dry-run). For example:

$ helm install -n actions-runner foo oci://ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set --set githubConfigSecret=github-access --set githubConfigUrl=https://github.com/CHARM-Tx --dry-run
Pulled: ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set:0.8.1
Digest: sha256:36a1f7a07ae5a3b15a9d190cf492ab66dd3a1302f37bde2f1ce5a6660592eb10
Error: INSTALLATION FAILED: execution error at (gha-runner-scale-set/templates/manager_role_binding.yaml:17:11): No gha-rs-controller deployment found using label (app.kubernetes.io/part-of=gha-rs-controller). Consider setting controllerServiceAccount.name in values.yaml to be explicit if you think the discovery is wrong.

The issue is that the chart uses lookup functionality, which requires contacting the Kubernetes API server. Passing --dry-run=server allows lookups to succeed, as of helm/helm#9426.

I would like Pulumi to also support this option, so I can install the Helm chart with Pulumi.

Affected area/feature

This affects the helm.v3.Release resource (and possibly helm.v3.Chart).

@kwohlfahrt kwohlfahrt added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jan 23, 2024
@mjeffryes mjeffryes added area/helm and removed needs-triage Needs attention from the triage team labels Jan 25, 2024
@mjeffryes
Copy link
Contributor

thanks for filing this ticket @kwohlfahrt, I'll add it to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants