Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for StatefulSet awaiter #313

Closed
lblackstone opened this issue Dec 4, 2018 · 3 comments · Fixed by #673
Closed

Improve error messages for StatefulSet awaiter #313

lblackstone opened this issue Dec 4, 2018 · 3 comments · Fixed by #673
Assignees
@lblackstone
Labels
area/await-logic area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally kind/enhancement Improvements or new features
Projects
Q3 Kubernetes
Milestone
0.25

Comments

@lblackstone
Copy link
Member

lblackstone commented Dec 4, 2018 •
edited
Loading

See #307 (comment)

Specifically, change the following:

"Failed to observe the expected number of ready replicas" -> "x out of y replicas succeeded readiness checks"

".status.currentRevision does not match .status.updateRevision" -> "StatefulSet controller failed to advance from revision %q to revision %q"
@lblackstone lblackstone self-assigned this Dec 4, 2018
@hausdorff hausdorff added kind/enhancement Improvements or new features area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally priority/P1 and removed area/inner-dev-loop labels Dec 18, 2018
@hausdorff hausdorff added this to the 0.21 milestone Dec 18, 2018
@lblackstone
Copy link
Member Author

This work will follow completion of #452
Moving to M22

@lblackstone lblackstone modified the milestones: 0.21, 0.22 Feb 25, 2019
@lblackstone lblackstone removed this from the 0.22 milestone Mar 18, 2019
@hausdorff hausdorff added this to backlog in Q3 Kubernetes Jul 22, 2019
@lukehoban
Copy link
Member

What is the actual issue being tracked here?

@lukehoban lukehoban added this to the 0.26 milestone Jul 25, 2019
@lblackstone
Copy link
Member Author

We need to standardize and improve the reported error messages from the k8s awaiters so that it's clear what went wrong and how to fix. I updated the description to be clearer.

@lblackstone lblackstone mentioned this issue Jul 30, 2019
Merged
@lblackstone lblackstone modified the milestones: 0.26, 0.25 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
area/await-logic area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally kind/enhancement Improvements or new features
Projects
No open projects
Q3 Kubernetes
backlog
Milestone
0.25
Development

Successfully merging a pull request may close this issue.

Improve error messages for StatefulSet pulumi/pulumi-kubernetes
4 participants
@lukehoban @pgavlin @hausdorff @lblackstone