Annotations will fail on computed values

[lblackstone]

Problem description

• Other: The provider won't handle computed values properly for annotations during preview. Labels have proper error handling for this case, so it should be straightforward to copy that logic and return an error if appropriate.

pulumi-kubernetes/pkg/metadata/annotations.go

Lines 50 to 72 in 5e311f8

	func SetAnnotation(obj *unstructured.Unstructured, key, value string) {
	// Note: Cannot use obj.GetAnnotations() here because it doesn't properly handle computed values from preview.
	// During preview, don't set annotations if the metadata or annotation contains a computed value since there's
	// no way to insert data into the computed object.
	metadataRaw := obj.Object["metadata"]
	if isComputedValue(metadataRaw) {
	return
	}
	metadata := metadataRaw.(map[string]interface{})
	annotationsRaw, ok := metadata["annotations"]
	if isComputedValue(annotationsRaw) {
	return
	}
	var annotations map[string]interface{}
	if !ok {
	annotations = make(map[string]interface{})
	} else {
	annotations = annotationsRaw.(map[string]interface{})
	}
	annotations[key] = value
	metadata["annotations"] = annotations
	}

can possibly error

pulumi-kubernetes/pkg/metadata/labels.go

Lines 32 to 72 in 5e311f8

	func TrySetLabel(obj *unstructured.Unstructured, key, value string) (succeeded bool, err error) {
	// Note: Cannot use obj.GetLabels() here because it doesn't properly handle computed values from preview.
	// During preview, don't set labels if the metadata or label contains a computed value since there's
	// no way to insert data into the computed object.
	metadataRaw, ok := obj.Object["metadata"]
	if isComputedValue(metadataRaw) {
	return false, nil
	}
	var isMap bool
	var metadata map[string]interface{}
	if !ok {
	metadata = map[string]interface{}{}
	obj.Object["metadata"] = metadata
	} else {
	metadata, isMap = metadataRaw.(map[string]interface{})
	if !isMap {
	return false, fmt.Errorf("expected .metadata to be a map[string]interface{}, got %q",
	reflect.TypeOf(metadata))
	}
	}
	labelsRaw, ok := metadata["labels"]
	if isComputedValue(labelsRaw) {
	return false, nil
	}
	var labels map[string]interface{}
	if !ok {
	labels = make(map[string]interface{})
	} else {
	labels, isMap = labelsRaw.(map[string]interface{})
	if !isMap {
	return false, fmt.Errorf("expected .metadata.labels to be a map[string]interface{}, got %q",
	reflect.TypeOf(labels))
	}
	}
	labels[key] = value
	metadata["labels"] = labels
	return true, nil
	}

is an example of proper handling