Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote path input #21

Open
jkodroff opened this issue Feb 17, 2023 · 0 comments
Open

Add remote path input #21

jkodroff opened this issue Feb 17, 2023 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@jkodroff
Copy link
Member

jkodroff commented Feb 17, 2023

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

It would be super helpful to allow us to specify the key under which our folder should be synced (asking specifically about S3 here). For example,

I want to be able to do this:

const folderSync = new syncedFolder.S3BucketFolder("environment-vpc", {
  acl: aws.s3.PublicReadAcl,
  bucketName: bucket.bucket,
  objectKey: "environment-vpc",
  path: "../environment-vpc",
}, {
  dependsOn: rmNodeModules,
});

In order to get local file ../environment-vpc/foo.txt to sync to s3://my-bucket/environment-vpc/foo.txt. Without the objectKey option, I have to reorg my code to move ../environment-vpc up a level to ../proton-templates/environment-vpc in my local filesystem and I have to sync all 3 planned folders now under proton-templates in a single S3BucketFolder resource. (I would prefer them to be separate.)

@jkodroff jkodroff added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 17, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants