Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping all explicit name parameters from converted examples. #1783

Closed
VenelinMartinov opened this issue Mar 22, 2024 · 1 comment
Closed

Consider dropping all explicit name parameters from converted examples. #1783

VenelinMartinov opened this issue Mar 22, 2024 · 1 comment
Assignees
@iwahbe
Labels
area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Mar 22, 2024 •
edited
Loading

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In terraform, the user has to specify the name of a resource explicitly. In pulumi, we have auto-naming so that is unnecessary and is even counter-productive - it causes name clashes etc.

We should consider dropping all explicit names from examples. For example the basic usage of a lambda function: https://www.pulumi.com/registry/packages/aws/api-docs/lambda/function/#basic-example

Lambda issue: pulumi/pulumi-aws#3682

Affected area/feature
@VenelinMartinov VenelinMartinov added needs-triage Needs attention from the triage team kind/enhancement Improvements or new features area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen labels Mar 22, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Mar 22, 2024
Closed
@iwahbe iwahbe added resolution/duplicate This issue is a duplicate of another issue and removed needs-triage Needs attention from the triage team labels Mar 26, 2024
@iwahbe
Copy link
Member

iwahbe commented Mar 26, 2024

This is a duplicate of pulumi/pulumi-converter-terraform#122.

@iwahbe iwahbe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iwahbe @VenelinMartinov