Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in pulumi stack ls latency #10219

Closed
mikhailshilkov opened this issue Jul 22, 2022 · 5 comments · Fixed by #10221
Closed

Regression in pulumi stack ls latency #10219

mikhailshilkov opened this issue Jul 22, 2022 · 5 comments · Fixed by #10221
Assignees
@aq17
Labels
area/cli UX of using the CLI (args, output, logs) impact/performance Something is slower than expected impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone
0.75

Comments

@mikhailshilkov
Copy link
Member

What happened?

pulumi stack ls -a takes up to a few minutes in organizations with large stacks

Based on perf traces, it appears that the CLI is doing an api/getStack on every stack which is taking ~200ms per stack.

It looks like it's a recent regression in #10059

Steps to reproduce

pulumi stack ls -a

Expected Behavior

Executes within a second or so

Actual Behavior

Takes up to 3-5 minutes based on user reports

Versions used

CLI 3.36.0, Pulumi Service backend

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@mikhailshilkov mikhailshilkov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team impact/performance Something is slower than expected impact/regression Something that used to work, but is now broken and removed needs-triage Needs attention from the triage team labels Jul 22, 2022
@mikhailshilkov
Copy link
Member Author

@aq17 Let's revert #10059 and see if there are other ways to solve the original ask (even if it's not simple)

@mikhailshilkov mikhailshilkov added area/cli UX of using the CLI (args, output, logs) p1 Bugs severe enough to be the next item assigned to an engineer labels Jul 22, 2022
@Frassle
Copy link
Member

Frassle commented Jul 22, 2022

We probably need to talk to service team to get this information raised on the right endpoint.

@aq17 aq17 self-assigned this Jul 22, 2022
@aq17
Copy link
Contributor

aq17 commented Jul 22, 2022

@mikhailshilkov @Frassle PR to revert merged; should we close this issue and re-open the discussion with service team elsewhere, or leave this open?

@dixler
Copy link
Contributor

dixler commented Jul 22, 2022

Takes up to 3-5 minutes based on user reports

thanks. can you link the user reports?

@mikhailshilkov
Copy link
Member Author

thanks. can you link the user reports?

No, they were not public. Basically, the command execution time is (was) linear as the number of user's stacks grows.

@mikhailshilkov mikhailshilkov added the resolution/fixed This issue was fixed label Jul 25, 2022
@mikhailshilkov mikhailshilkov mentioned this issue Jul 25, 2022
Merged
3 tasks
@mikhailshilkov mikhailshilkov added this to the 0.75 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aq17 aq17

Labels
area/cli UX of using the CLI (args, output, logs) impact/performance Something is slower than expected impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.75
Development

Successfully merging a pull request may close this issue.

Revert "Add last status to pulumi stack ls output" pulumi/pulumi
4 participants
@Frassle @mikhailshilkov @dixler @aq17