Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify TypeScript version in GitHub action #792

Open
slavafomin opened this issue Nov 29, 2022 · 3 comments
Open

Specify TypeScript version in GitHub action #792

slavafomin opened this issue Nov 29, 2022 · 3 comments
Labels
awaiting-feedback impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features

Comments

@slavafomin
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Hello! I'm using Pulumi Service via Pulumi GitHub Actions and it looks like it uses an outdated version of TypeScript, because it can't recognize some compiler directives that I use. Effectively this prevents me from extending reusable TypeScript configurations and I have to manually copy the configuration and downgrade it by removing/changing the problematic options.

It would be much better if Pulumi would respect and use the TypeScript compiler listed as a project dependency. E.g.: npx tsc (node_modules/typescript/bin/tsc).

Affected area/feature

I believe it is related to the Pulumi Service product.

@slavafomin slavafomin added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 29, 2022
@Frassle Frassle transferred this issue from pulumi/pulumi Nov 29, 2022
@Frassle Frassle changed the title Specify TypeScript version Specify TypeScript version in GitHub action Nov 29, 2022
@EvanBoyle EvanBoyle transferred this issue from pulumi/pulumi-cloud-requests Dec 5, 2022
@RobbieMcKinstry
Copy link
Contributor

Hi @slavafomin I'm not sure I understand. It sounds like the issue is that the Pulumi CLI uses a pinned version of TypeScript that's incompatable with your project, not that this action's TypeScript build is incompatible.

It sounds like you're hitting this issue here.
If that's the case, I'll just briefly reiterate what makes that issue difficult to solve: moving TypeScript to a peer dependency (thus allowing you to provide your own version in your package.json) is a breaking change. We might be able to work around that with a dynamic import, but we need a brief spike to figure that out.

@RobbieMcKinstry RobbieMcKinstry added impact/breaking Fixing this issue will require a breaking change awaiting-feedback and removed needs-triage Needs attention from the triage team labels Dec 5, 2022
@RobbieMcKinstry
Copy link
Contributor

This package uses TypesScript v4.1.3. Is your project using features from a newer release?
The Pulumi NodeJS runtime bundles v3.8 IIRC.

@RobbieMcKinstry
Copy link
Contributor

Hi @slavafomin, happy New Year. I just wanted to follow up on this issue. Have you had a chance to confirm you're encountering pulumi/pulumi#8177?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants