Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/alias either provider or providers and add a deprecation warning. #11503

Open
rshade opened this issue Dec 1, 2022 · 3 comments
Open
Labels
area/engine Pulumi engine area/sdks Pulumi language SDKs kind/enhancement Improvements or new features

Comments

@rshade
Copy link
Contributor

rshade commented Dec 1, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In troubleshooting #11316, it was discovered that the usecase for provider and providers is very confusing. A new user would easily stumble on this. I suggest we pick a more descriptive set of names, and go ahead and alias them now for future deprecation.

Affected area/feature

Pulumi SDK

@rshade rshade added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Dec 1, 2022
@Frassle Frassle added area/sdks Pulumi language SDKs area/engine Pulumi engine and removed needs-triage Needs attention from the triage team labels Dec 2, 2022
@Frassle
Copy link
Member

Frassle commented Dec 2, 2022

I think these options need an overhaul in general but I suspect it will all have to wait for 4.0, there's too many uses of these options already that making changes here will break a lot of current users.

@rshade
Copy link
Contributor Author

rshade commented Dec 2, 2022

My overarching reason to start brainstorming and planning those changes now is because we have so many users using it already we need them to start thinking about the change and not introduce it shockingly in 4.0. If we create the alias now or shortly in future release we can give them plenty of time to upgrade or comment on the change.

@Frassle
Copy link
Member

Frassle commented Dec 2, 2022

I don't think it's just the name that's the issue here. I don't think the semantics of these are consistent across languages either, or across MLCs vs in program components. It's all a bit of a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Pulumi engine area/sdks Pulumi language SDKs kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants