Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Lint failing on CI, blocking merges #11542

Closed
AaronFriel opened this issue Dec 6, 2022 · 1 comment · Fixed by #11541
Closed

Python Lint failing on CI, blocking merges #11542

AaronFriel opened this issue Dec 6, 2022 · 1 comment · Fixed by #11541
Assignees
Labels
area/build CI/CD for pulumi/pulumi kind/bug Some behavior is incorrect or out of spec p0 Bugs severe enough to interrupt existing work resolution/fixed This issue was fixed

Comments

@AaronFriel
Copy link
Member

Jobs have begun failing with errors in linting the Python SDK, specifically failing on running mypy: https://github.com/pulumi/pulumi/actions/runs/3624968763/jobs/6112540141

Logs:

. venv/*/activate && \
	MYPYPATH=./stubs python -m mypy ./lib/pulumi --config-file=mypy.ini
lib/pulumi/runtime/invoke.py:[19](https://github.com/pulumi/pulumi/actions/runs/3624968763/jobs/6112540141#step:16:22)0: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/pulumi/runtime/invoke.py:236: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/pulumi/runtime/invoke.py:251: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/pulumi/runtime/rpc.py:5[21](https://github.com/pulumi/pulumi/actions/runs/3624968763/jobs/6112540141#step:16:24): error: Argument 1 to "FileAsset" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "Union[str, PathLike[Any]]"  [arg-type]
lib/pulumi/runtime/rpc.py:5[23](https://github.com/pulumi/pulumi/actions/runs/3624968763/jobs/6112540141#step:16:26): error: Argument 1 to "StringAsset" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:5[25](https://github.com/pulumi/pulumi/actions/runs/3624968763/jobs/6112540141#step:16:28): error: Argument 1 to "RemoteAsset" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:534: error: Argument 1 to "FileArchive" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:536: error: Argument 1 to "RemoteArchive" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:577: error: Argument 1 to "_parse_urn" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:586: error: Argument 2 to "get_resource_package" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:589: error: Argument 3 to "construct_provider" of "ResourcePackage" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:592: error: Argument 3 to "get_resource_module" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:594: error: Argument 3 to "construct" of "ResourceModule" has incompatible type "Union[Struct, ListValue, str, float, bool, None]"; expected "str"  [arg-type]
lib/pulumi/runtime/rpc.py:601: error: Incompatible return value type (got "Union[Struct, ListValue, str, float, bool, None]", expected "Resource")  [return-value]
@AaronFriel AaronFriel added p0 Bugs severe enough to interrupt existing work area/build CI/CD for pulumi/pulumi labels Dec 6, 2022
@bors bors bot closed this as completed in bb1ef96 Dec 6, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 6, 2022
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@pulumi-bot pulumi-bot reopened this Dec 6, 2022
@aq17 aq17 added the kind/bug Some behavior is incorrect or out of spec label Dec 6, 2022
@aq17 aq17 closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build CI/CD for pulumi/pulumi kind/bug Some behavior is incorrect or out of spec p0 Bugs severe enough to interrupt existing work resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants