Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pulumi new "install dependencies" implementation into the language plugins #1334

Closed
justinvp opened this issue May 7, 2018 · 1 comment · Fixed by #9294
Closed

Move pulumi new "install dependencies" implementation into the language plugins #1334

justinvp opened this issue May 7, 2018 · 1 comment · Fixed by #9294
Labels
area/cli UX of using the CLI (args, output, logs) kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone

Comments

@justinvp
Copy link
Member

justinvp commented May 7, 2018

This is implemented inside pulumi new for a simpler initial implementation, but it really should live inside the language plugins long-term. Then pulumi new would just call the language plugin (e.g. InstallDependencies or PrepareProject) to install dependencies, and the language plugin would handle doing whatever it needs to do. That way, if/when we add new languages, pulumi new would just work with the new language.

Since there is a gRPC boundary between the CLI and language plugin, the tricky part will be making sure we can show the Stdout and Stderr of any commands (e.g. npm install) run by the language plugin.

@justinvp justinvp added area/cli UX of using the CLI (args, output, logs) kind/engineering labels May 7, 2018
@justinvp justinvp added this to the 0.16 milestone May 7, 2018
@justinvp justinvp self-assigned this May 7, 2018
@justinvp justinvp modified the milestones: 0.16, 0.17 Aug 3, 2018
@lukehoban lukehoban modified the milestones: 0.17, 0.18 Aug 17, 2018
@lukehoban lukehoban modified the milestones: 0.18, 0.19 Sep 21, 2018
@justinvp justinvp modified the milestones: 0.19, 0.20 Oct 29, 2018
@justinvp justinvp removed this from the 0.20 milestone Dec 5, 2018
@justinvp
Copy link
Member Author

justinvp commented May 21, 2020

We have a similar issue for Policy Packs. We need to be able to package a policy pack and then subsequently install it and its dependencies. Right now we effectively have switch statements, but really we should be deferring to the analyzer plugins to do this.

@lukehoban lukehoban added the kind/engineering Work that is not visible to an external user label Dec 30, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 3, 2022
@mikhailshilkov mikhailshilkov added this to the 0.71 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli UX of using the CLI (args, output, logs) kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants