Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start linting all TypeScript code with ESLint #4698

Closed
1 of 3 tasks
mikhailshilkov opened this issue May 26, 2020 · 5 comments · Fixed by #7719 or #10395
Closed
1 of 3 tasks

Start linting all TypeScript code with ESLint #4698

mikhailshilkov opened this issue May 26, 2020 · 5 comments · Fixed by #7719 or #10395
Labels
area/tooling good-first-issue Start here if you'd like to start contributing to Pulumi kind/engineering Work that is not visible to an external user language/javascript resolution/fixed This issue was fixed

Comments

@mikhailshilkov
Copy link
Member

mikhailshilkov commented May 26, 2020 •
edited by justinvp

TSLint that we currently use in several places is deprecated in favor of ESLint.

I suggest using ESLint consistently:

  • Replace TSLint with ESLint in pulumi/pulumi (Use ESlint instead of TSlint #7719)
  • Replace TSLint with ESLint in pulumi/examples
  • Introduce ESLint in all provider repositories starting with providers with any hand-written mixins
@stack72
Copy link
Contributor

stack72 commented May 26, 2020

Kinda tracked here - pulumi/examples#520

@emiliza emiliza added the good-first-issue Start here if you'd like to start contributing to Pulumi label Jul 28, 2021
@horacehylee
Copy link
Contributor

Hi, may I volunteer to help with this issue?

@mikhailshilkov
Copy link
Member Author

@horacehylee Definitely! Thank you!

@horacehylee horacehylee mentioned this issue Aug 7, 2021
Merged
3 tasks
@horacehylee
Copy link
Contributor

horacehylee commented Aug 7, 2021 •
edited

@mikhailshilkov I have raised a PR for migrating to ESlint, could you please take a look?

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 10, 2021
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@pulumi-bot pulumi-bot reopened this Aug 10, 2021
@justinvp justinvp added kind/engineering Work that is not visible to an external user and removed resolution/fixed This issue was fixed labels Aug 10, 2021
@kpitzen kpitzen mentioned this issue Aug 15, 2022
Merged
3 tasks
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tooling good-first-issue Start here if you'd like to start contributing to Pulumi kind/engineering Work that is not visible to an external user language/javascript resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
6 participants
@stack72 @justinvp @mikhailshilkov @emiliza @horacehylee @pulumi-bot