Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace files produced by pulumi --tracing do not show AWS provider calls #7571

Closed
Tracked by #11598
t0yv0 opened this issue Jul 19, 2021 · 2 comments
Closed
Tracked by #11598

Trace files produced by pulumi --tracing do not show AWS provider calls #7571

t0yv0 opened this issue Jul 19, 2021 · 2 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@t0yv0
Copy link
Member

t0yv0 commented Jul 19, 2021

To reproduce:

  1. checkout exampes/aws-go-s3-folder
  2. pulumi up --tracing file:./up.trace
  3. PULUMI_DEBUG_COMMANDS=1 pulumi view-trace "$1"

Expected:

Visibility into what the AWS provider is doing, in particular spans around the network calls it generates to talk to AWS.

Actual:

No spans coming from the AWS provider.

Discussion:

There might be two issues going on here, first we need to verify that --tracing flag is getting passed correctly to the AWS plugin; second, check that AWS provider has the appropriate span annotations against the opentracing API. This may be broken out into a separate issue.

Workaround:

There is some indirect visibility via spans coming from the engine such as /pulumirpc.ResourceProvider/Create. These are client-side spans produced by the gRPC client talking to the provider's gRPC server.

Affected feature

Performance visibility.

@t0yv0 t0yv0 added the kind/enhancement Improvements or new features label Jul 19, 2021
@t0yv0
Copy link
Member Author

t0yv0 commented Jul 6, 2022

This got fixed in #9980 - note that it turns out the fix only affected using file: based AppDash tracing. When using a Jaeger server for tracing as described inhttps://www.pulumi.com/docs/support/troubleshooting/ the traces propagate perfectly already without the fix.

@t0yv0 t0yv0 closed this as completed Jul 6, 2022
@pulumi-bot pulumi-bot reopened this Jul 6, 2022
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: resolution/

@t0yv0 t0yv0 self-assigned this Jul 6, 2022
@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Jul 6, 2022
@t0yv0 t0yv0 closed this as completed Jul 6, 2022
@mikhailshilkov mikhailshilkov added this to the 0.74 milestone Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants