Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI needs to be resilient to network flakiness #763

Closed
joeduffy opened this issue Dec 23, 2017 · 1 comment
Closed

CLI needs to be resilient to network flakiness #763

joeduffy opened this issue Dec 23, 2017 · 1 comment
Assignees
@joeduffy
Labels
area/cli UX of using the CLI (args, output, logs) impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features
Milestone
0.9.2

Comments

@joeduffy
Copy link
Member

We received a bug report from a user, who saw the following error message during an update to their stack: error: waiting for update: calling API: performing HTTP request: Get https://api.pulumi.com/api/orgs/<org>/programs/<project>/stacks/<stack>/update/008694d1-c03d-4674-a29a-e04ca1352866?afterIndex=1513992748356531783: read tcp 192.168.1.22:49324->52.88.12.77:443: read: operation timed out. Notably the 192.168.1.22 address is the user's PC and 52.88.12.77 is the api.pulumi.com endpoint.

It would appear there was a flaky network problem that interrupted the querying of an update's status. We should add appropriate retry logic for this case explicitly.

Note that the ability to reattach the CLI to the current deployment would have come in handy here. Absent this, it appeared something truly catastrophic had occurred, and there wasn't much recourse.
@joeduffy joeduffy added area/cli UX of using the CLI (args, output, logs) impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features labels Dec 23, 2017
@joeduffy joeduffy added this to the 0.9.2 milestone Dec 23, 2017
@joeduffy joeduffy self-assigned this Dec 23, 2017
@joeduffy
Copy link
Member Author

Fixed in 86c1e7a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeduffy joeduffy

Labels
area/cli UX of using the CLI (args, output, logs) impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features
Projects
None yet
Milestone
0.9.2
Development

No branches or pull requests
1 participant
@joeduffy