Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program codegen generates invalid TypeScript lambdas. #8067

Closed
iwahbe opened this issue Sep 27, 2021 · 0 comments · Fixed by #11461
Closed

Program codegen generates invalid TypeScript lambdas. #8067

iwahbe opened this issue Sep 27, 2021 · 0 comments · Fixed by #11461
Assignees
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec language/go resolution/fixed This issue was fixed
Milestone

Comments

@iwahbe
Copy link
Member

iwahbe commented Sep 27, 2021

The aws-eks-pp TypeScript test fails with parsing errors. We emitted zones.names.map((k, v) => {key: k, value: v}) which is invalid. We should have emitted zones.names.map((k, v) => ({key: k, value: v}))

Steps to reproduce

  1. cd pkg/codegen/internal/test/testdata/aws-eks-pp
  2. yarn run tsc --noEmit aws-eks.ts

Expected: Clean compile
Actual:

yarn run v1.22.11
warning package.json: No license field
$ /Users/ianwahbe/Projects/pulumi/pulumi/pkg/codegen/internal/test/testdata/aws-eks-pp/node_modules/.bin/tsc --noEmit aws-eks.ts
aws-eks.ts(34,65): error TS1005: ';' expected.
aws-eks.ts(47,65): error TS1005: ';' expected.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Note: there are probably other errors behind this test. We can file file issues for those when this test is solved.

@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec area/codegen SDK-gen, program-gen, convert labels Sep 27, 2021
@iwahbe iwahbe self-assigned this Nov 23, 2022
@iwahbe iwahbe added this to the 0.81 milestone Nov 24, 2022
@bors bors bot closed this as completed in 35f8427 Nov 24, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec language/go resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants