[codegen/typescript] Call site defaults for plain Pulumi Object types #8400

iwahbe · 2021-11-11T01:57:02Z

Description

Apply a default function when a object type is passed as an argument to Resource.

Partial fix for: #8132

Note: the massive number of files changes is because I needed to change the name of our registration inputs to resourceInputs. The old name (just inputs) conflicted with the inputs package. Changes were made to nodejs/gen.go and the test added is called env-helper (in codegen/internal/test/testdata).

Checklist

I have added tests that prove my fix is effective or that my feature works

I have updated the CHANGELOG-PENDING file with my change

Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

github-actions · 2021-11-11T02:01:23Z

Diff for pulumi-azuread with merge commit 1c61fa9

github-actions · 2021-11-11T02:01:39Z

Diff for pulumi-random with merge commit 1c61fa9

github-actions · 2021-11-11T02:04:54Z

Diff for pulumi-kubernetes with merge commit 1c61fa9

github-actions · 2021-11-11T02:06:12Z

Diff for pulumi-gcp with merge commit 1c61fa9

github-actions · 2021-11-11T02:14:32Z

Diff for pulumi-azure with merge commit 1c61fa9

github-actions · 2021-11-11T02:25:39Z

Diff for pulumi-aws with merge commit 1c61fa9

github-actions · 2021-11-11T18:51:15Z

Diff for pulumi-random with merge commit b646444

github-actions · 2021-11-11T18:51:48Z

Diff for pulumi-azuread with merge commit b646444

github-actions · 2021-11-11T18:52:24Z

Diff for pulumi-kubernetes with merge commit b646444

github-actions · 2021-11-11T18:53:40Z

Diff for pulumi-azuread with merge commit b30049e

github-actions · 2021-11-11T18:53:47Z

Diff for pulumi-random with merge commit b30049e

github-actions · 2021-11-11T18:55:30Z

Diff for pulumi-gcp with merge commit b646444

github-actions · 2021-11-11T18:55:52Z

Diff for pulumi-kubernetes with merge commit b30049e

github-actions · 2021-11-11T18:57:13Z

Diff for pulumi-gcp with merge commit b30049e

github-actions · 2021-11-11T19:04:53Z

Diff for pulumi-azure with merge commit b646444

github-actions · 2021-11-11T19:07:52Z

Diff for pulumi-azure with merge commit b30049e

github-actions · 2021-11-11T19:13:33Z

Diff for pulumi-aws with merge commit b646444

github-actions · 2021-11-11T19:19:06Z

Diff for pulumi-aws with merge commit b30049e

github-actions · 2021-11-11T19:22:55Z

Diff for pulumi-azuread with merge commit be80baf

github-actions · 2021-11-17T19:24:42Z

Diff for pulumi-random with merge commit f6f5c95

github-actions · 2021-11-17T19:24:46Z

Diff for pulumi-azuread with merge commit f6f5c95

github-actions · 2021-11-17T19:26:17Z

Diff for pulumi-kubernetes with merge commit f6f5c95

github-actions · 2021-11-17T19:29:03Z

Diff for pulumi-gcp with merge commit f6f5c95

github-actions · 2021-11-17T19:36:06Z

Diff for pulumi-azure with merge commit f6f5c95

github-actions · 2021-11-17T19:44:34Z

Diff for pulumi-aws with merge commit f6f5c95

@praneetloke

Credit to @praneetloke

github-actions · 2021-11-17T20:23:45Z

Diff for pulumi-azure-native with merge commit f6f5c95

t0yv0 · 2021-11-17T20:54:08Z

pkg/codegen/docs/gen.go

@@ -1957,8 +1957,14 @@ func (dctx *docGenContext) generatePackage(tool string, pkg *schema.Package) (ma

 	glog.V(3).Infoln("generating package docs now...")
 	files := fs{}
-	for _, mod := range dctx.modules() {
-		if err := mod.gen(files); err != nil {
+	modules := []string{}


Oof nice find. Anything else using dctx.modules() like this?

This is the only one

t0yv0

LGTM

github-actions · 2021-11-17T23:19:22Z

Diff for pulumi-random with merge commit 5306448

github-actions · 2021-11-17T23:20:07Z

Diff for pulumi-azuread with merge commit 5306448

github-actions · 2021-11-17T23:22:26Z

Diff for pulumi-kubernetes with merge commit 5306448

github-actions · 2021-11-17T23:23:55Z

Diff for pulumi-gcp with merge commit 5306448

github-actions · 2021-11-17T23:30:16Z

Diff for pulumi-azure with merge commit 5306448

github-actions · 2021-11-17T23:36:57Z

Diff for pulumi-aws with merge commit 5306448

github-actions · 2021-11-18T17:46:09Z

Diff for pulumi-azuread with merge commit bf51d5d

github-actions · 2021-11-18T17:46:23Z

Diff for pulumi-random with merge commit bf51d5d

github-actions · 2021-11-18T17:47:50Z

Diff for pulumi-kubernetes with merge commit bf51d5d

github-actions · 2021-11-18T17:49:18Z

Diff for pulumi-gcp with merge commit bf51d5d

github-actions · 2021-11-18T17:57:03Z

Diff for pulumi-azure with merge commit bf51d5d

github-actions · 2021-11-18T18:03:03Z

Diff for pulumi-aws with merge commit bf51d5d

github-actions · 2021-11-18T18:35:28Z

Diff for pulumi-azure-native with merge commit bf51d5d

iwahbe added 6 commits November 10, 2021 12:16

Add test case

77962bb

Fix tests

4553508

Add test dependencies correctly

db71b17

Feed through error handling

3e9584a

Include test output

309e33f

Get types to line up

05520e8

iwahbe marked this pull request as draft November 11, 2021 01:57

Add remaining test files

302f4c9

iwahbe changed the title ~~iwahbe/8132/env variable helpers~~ [codegen/typescript] iwahbe/8132/env variable helpers Nov 11, 2021

Update changelog

d53ab10

Correctly find type paths

53e480a

iwahbe added 2 commits November 17, 2021 10:47

Another attempt at _index.md

7827824

Make module generation deterministic

29938d4

pulumi-bot mentioned this pull request Nov 17, 2021

Preview resource docs changes for pulumi/pulumi#8400 pulumi/docs#6858

Closed

Fix docs generation

e86b296

Credit to @praneetloke

iwahbe requested a review from t0yv0 November 17, 2021 20:47

t0yv0 reviewed Nov 17, 2021

View reviewed changes

t0yv0 approved these changes Nov 17, 2021

View reviewed changes

Merge branch 'master' into iwahbe/8132/env-variable-helpers

ec1ea21

iwahbe merged commit 3e2f365 into master Nov 18, 2021

pulumi-bot deleted the iwahbe/8132/env-variable-helpers branch November 18, 2021 20:23

[codegen/typescript] Call site defaults for plain Pulumi Object types #8400

[codegen/typescript] Call site defaults for plain Pulumi Object types #8400

Conversation

iwahbe commented Nov 11, 2021 • edited

Description

Checklist

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

t0yv0 Nov 17, 2021

Choose a reason for hiding this comment

iwahbe Nov 17, 2021

Choose a reason for hiding this comment

t0yv0 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

github-actions bot commented Nov 18, 2021

iwahbe commented Nov 11, 2021 •

edited