Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/python] Check for pulumiplugin.json on package lookup #8515

Merged
merged 6 commits into from Dec 2, 2021
Merged

[sdk/python] Check for pulumiplugin.json on package lookup #8515

merged 6 commits into from Dec 2, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 30, 2021 •
edited

Description

Check for pulumiplugin.json as a way to find if a package is a pulumi package.

Fixes #7243

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Nov 30, 2021
@iwahbe
Update CHANGELOG_PENDING.md
c717cb8
@iwahbe
Add tests
2105d51 
Tests caught a bug in the implementation of `LoadPulumiPluginJSON`. +1
for tests.
@iwahbe iwahbe requested review from justinvp and a team November 30, 2021 21:42
justinvp
justinvp approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe merged commit a685026 into master Dec 2, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/7243/python-check-for-pulumiplugin-json branch December 2, 2021 00:07
@justinvp justinvp mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Look for non pulumi- prefixed packages in GetRequiredPlugins
2 participants
@iwahbe @justinvp