Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test maintenance: re-enable asset_test.go tests that are skipped on Windows #8647

Open
t0yv0 opened this issue Dec 29, 2021 · 0 comments
Open
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Dec 29, 2021

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

Currently a few asset_test.go tests are skipped on Windows. I've put some work into fixing them but it's a bit involved and the passing tests on my Windows test machine did not result in a passing PR, so backlogging it here for the moment.

The key issues are:

  • sometimes git checks out test data files with CRLF, affecting checksums and asserts in the tests
  • tests assume /dev/null exists
  • there are issues with path asserts \ based paths instead of / based paths
  • there are issues with constructing file URLs from paths containing C: drive prefix

While most of the issues are test-only, there is something suspicious around asserts against paths of the packed files in an Archive.. That is we probably want Archives generated on Windows to be identical to the ones generated on Linux/Mac so they are portable across OS-es, this is something worth double-checking.

Steps to reproduce

Expected:
Actual:

@t0yv0 t0yv0 added the kind/bug Some behavior is incorrect or out of spec label Dec 29, 2021
@justinvp justinvp added kind/engineering Work that is not visible to an external user and removed kind/bug Some behavior is incorrect or out of spec labels Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants