You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)
Issue details
Currently a few asset_test.go tests are skipped on Windows. I've put some work into fixing them but it's a bit involved and the passing tests on my Windows test machine did not result in a passing PR, so backlogging it here for the moment.
The key issues are:
sometimes git checks out test data files with CRLF, affecting checksums and asserts in the tests
tests assume /dev/null exists
there are issues with path asserts \ based paths instead of / based paths
there are issues with constructing file URLs from paths containing C: drive prefix
While most of the issues are test-only, there is something suspicious around asserts against paths of the packed files in an Archive.. That is we probably want Archives generated on Windows to be identical to the ones generated on Linux/Mac so they are portable across OS-es, this is something worth double-checking.
Steps to reproduce
Expected:
Actual:
The text was updated successfully, but these errors were encountered:
Hello!
Issue details
Currently a few asset_test.go tests are skipped on Windows. I've put some work into fixing them but it's a bit involved and the passing tests on my Windows test machine did not result in a passing PR, so backlogging it here for the moment.
The key issues are:
/dev/null
exists\
based paths instead of/
based pathsWhile most of the issues are test-only, there is something suspicious around asserts against paths of the packed files in an Archive.. That is we probably want Archives generated on Windows to be identical to the ones generated on Linux/Mac so they are portable across OS-es, this is something worth double-checking.
Steps to reproduce
Expected:
Actual:
The text was updated successfully, but these errors were encountered: