Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a warning when using additionalSecretOutputs: ['id'] #8980

Closed
iwahbe opened this issue Feb 11, 2022 · 0 comments 路 Fixed by #9360
Closed

Issue a warning when using additionalSecretOutputs: ['id'] #8980

iwahbe opened this issue Feb 11, 2022 · 0 comments 路 Fixed by #9360
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@iwahbe
Copy link
Member

iwahbe commented Feb 11, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

As shown in #8946, a resource id cannot be made secret. In a sense, it's logical that additionalSecretOutputs: ['id'] doesn't work, as id is not an output. On the other hand, some resources assign a potentially-secret output value to resource ID, which is currently impossible to hide from plain text. To prevent users from relying on additionalSecretOutputs, we should warn when this is passed.

Affected area/feature

@iwahbe iwahbe added the kind/enhancement Improvements or new features label Feb 11, 2022
@iwahbe iwahbe self-assigned this Mar 17, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 7, 2022
@mikhailshilkov mikhailshilkov added this to the 0.71 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants