Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements for update plans #8985

Open
9 tasks
Frassle opened this issue Feb 14, 2022 · 0 comments
Open
9 tasks

UX improvements for update plans #8985

Frassle opened this issue Feb 14, 2022 · 0 comments
Labels
area/update-plans kind/enhancement Improvements or new features

Comments

@Frassle
Copy link
Member

Frassle commented Feb 14, 2022

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

  1. Consider renaming --save-plan to --plan-out so it sorts with "plan", or possibly just --out if we don't expect preview to output anything else.
  2. It's not clear what extension to use for plan files. Should we say it's JSON in the help text?
  3. Should pulumi up --plan x.json indicate somehow that it's using the plan file?
  4. It's might feel odd that pulumi up still runs a preview with a plan file. Again should we change the cli text to make it clear that the plan is being validated? Something like rather than "Previewing update (dev)" it can say "Applying plan (dev)", "Validating plan (dev)", or something?
  5. Related to above should it explicitly say, "Update preview verified to be consistent with plan x.json" or something.
  6. Should the cli print that it's generated and used a plan as part of pulumi up when no explicit plan has been passed in.
  7. Do we need an option to turn the auto planning off? --no-plan?
  8. Some error messages are not consistent:
    "error: resource X violates plan: properties changed: …"
    "error: create is not allowed by the plan: no steps were expected for this resource"
    First error has URN, second does not; first says "violates plan", second says "not allowed by plan"; perhaps just:
    "error: resource X violates plan: properties changed: …"
    "error: resource X violates plan: create not allowed, no steps were expected for this resource"
    IOW, always prefix with "resource X violates plan."
  9. Print a message with a link to more info about update plans when constraints fail. Something like "If you are seeing this, it means something changed between your preview and plan, or there is non-determinism in your Pulumi program. Read more here: https://pulumi.com/"
@Frassle Frassle added kind/enhancement Improvements or new features area/update-plans labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/update-plans kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant