Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi preview --expect-no-changes doesn't use different exit codes depending on the exit reason #8992

Open
piotr-bzdyl-vertexinc opened this issue Feb 15, 2022 · 5 comments
Labels
area/cli UX of using the CLI (args, output, logs) good-first-issue Start here if you'd like to start contributing to Pulumi help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features

Comments

@piotr-bzdyl-vertexinc
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

Steps to reproduce

pulumi preview --expect-no-changes uses a single exit code for both cases

  • there was an error while running preview of the changes e.g. due to network connectivity, issues with credentials etc.
  • there are some changes to the resources detected

This makes it cumbersome to differentiate between these two situations and require workarounds.

It would be better to have an option similar to https://www.terraform.io/cli/commands/plan#detailed-exitcode.

$ pulumi version
v3.24.1
@piotr-bzdyl-vertexinc piotr-bzdyl-vertexinc added the kind/bug Some behavior is incorrect or out of spec label Feb 15, 2022
@piotr-bzdyl-vertexinc piotr-bzdyl-vertexinc changed the title pulumi preview --expect-no-changes doesn't differentiate exit codes pulumi preview --expect-no-changes doesn't use different exit codes depending on the exit reason Feb 15, 2022
@mikhailshilkov mikhailshilkov added area/cli UX of using the CLI (args, output, logs) kind/enhancement Improvements or new features and removed kind/bug Some behavior is incorrect or out of spec labels Feb 15, 2022
@dixler
Copy link
Contributor

dixler commented Jul 27, 2022

related to #3897

@RobbieMcKinstry RobbieMcKinstry added good-first-issue Start here if you'd like to start contributing to Pulumi help-wanted We'd love your contributions on this issue labels Sep 8, 2022
@rshade
Copy link
Contributor

rshade commented Sep 16, 2022

related to #5144

@BigDwarf
Copy link

BigDwarf commented Apr 6, 2023

Hello @dixler , do you mind assigning this one to me if it is still a case? :)

@dixler
Copy link
Contributor

dixler commented Apr 6, 2023

Hello @dixler , do you mind assigning this one to me if it is still a case? :)

Hey again. Thanks for the interest. I brought this up with the team and we're going to need to put together a more comprehensive plan around exit codes first. Will follow up.

@gunzy83
Copy link

gunzy83 commented Oct 23, 2023

Hey again. Thanks for the interest. I brought this up with the team and we're going to need to put together a more comprehensive plan around exit codes first. Will follow up.

@dixler Did a plan get created on this? I think a few of us would be keen to help make this happen but without knowing the internal plans at Pulumi this will be stalled indefinitely. We have had a number of deploys proceed and then error when the preview error should have been caught first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli UX of using the CLI (args, output, logs) good-first-issue Start here if you'd like to start contributing to Pulumi help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

7 participants