Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests for devspace scripts #9027

Open
dixler opened this issue Feb 22, 2022 · 0 comments
Open

CI tests for devspace scripts #9027

dixler opened this issue Feb 22, 2022 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@dixler
Copy link
Contributor

dixler commented Feb 22, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

Added a mockpackage in #8893 and broke sdk/nodejs make install #9019, but CI didn't catch it.

Steps to reproduce

  1. Submit broken PR for make install in sdk/nodejs

Expected: tests fail
Actual: tests pass
@dixler dixler added the kind/bug Some behavior is incorrect or out of spec label Feb 22, 2022
@dixler dixler mentioned this issue Feb 22, 2022
Merged
3 tasks
@dixler dixler added kind/enhancement Improvements or new features and removed kind/bug Some behavior is incorrect or out of spec labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dixler