Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"completing deletion from previous update" should be run last #9979

Closed
wvanderdeijl opened this issue Jun 27, 2022 · 2 comments
Closed

"completing deletion from previous update" should be run last #9979

wvanderdeijl opened this issue Jun 27, 2022 · 2 comments
Labels
kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue

Comments

@wvanderdeijl
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

I love the feature that pulumi first creates all new resources and schedules the deletion of resources at the very end. But it seems that it does not do this if the pulumi up failed for whatever reason. On the next pulumi up the scheduled deleted resources are process first before creating any new resources. This can lead to errors where the resources cannot be deleted yet.

Take the next example:

  1. a stack has resource A which is used by resource B
  2. we do a pulumi up that needs to replace resource A and create resource Z. Pulumi could start by creating the replacement for resource A, schedules the old resource A for deletion and then tries to create resource Z and update resource B to use the new resource A. But if the creation of resource Z fails, pulumi aborts.
  3. We do another pulumi up and it starts with the scheduled deletion of the old resource A before doing any of the new work. But this new work would include updating resource B to use the replacement resource A. Since that hasn't run yet the deletion of the old resource A will fail as the cloud provider throws an error that this resource is still in use.

Is there a way to postpone the deletions from previous updates until after all the "rolling forward" has been done and queue those for the same time as all the deletions that get discovered in the current run?

Affected area/feature

Scheduling of the deletion from previous updates

@wvanderdeijl wvanderdeijl added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jun 27, 2022
@lukehoban
Copy link
Member

I believe this is the same issue tracked in #2948?

@mikhailshilkov mikhailshilkov added area/core resolution/duplicate This issue is a duplicate of another issue and removed needs-triage Needs attention from the triage team labels Jun 28, 2022
@mikhailshilkov
Copy link
Member

Yes, looks like like a duplicate to me. I'll close this issue - let me know if that's wrong.

@mikhailshilkov mikhailshilkov closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants