Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate StackReference code generation via pulumi convert #10260

Closed
Tracked by #269
AaronFriel opened this issue Jul 27, 2022 · 1 comment · Fixed by #10419
Closed
Tracked by #269

Inaccurate StackReference code generation via pulumi convert #10260

AaronFriel opened this issue Jul 27, 2022 · 1 comment · Fixed by #10419
Assignees
@aq17
Labels
area/codegen SDK-gen, program-gen, convert kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.77

Comments

@AaronFriel
Copy link
Member

Code generation assumes that the pulumi package should be interpreted like others, such as aws, and imported as @pulumi/pulumi-pulumi (nodejs) or via pulumi_pulumi (python), and so on.

The schema is also inaccurate for Python at least, as the name property in the Python SDK is stack_name.

This issue will track successfully generating code for each of our target languages via PCL.
@AaronFriel AaronFriel added kind/enhancement Improvements or new features area/codegen SDK-gen, program-gen, convert labels Jul 27, 2022
@AaronFriel AaronFriel self-assigned this Jul 27, 2022
@AaronFriel AaronFriel added this to the 0.76 milestone Jul 27, 2022
@Frassle
Copy link
Member

Frassle commented Jul 28, 2022

Might be worth syncing with @harribo11 as StackReference tests are one of the tests his looking at adding to the matrix test framework.

@mikhailshilkov mikhailshilkov modified the milestones: 0.76, 0.77 Aug 15, 2022
@AaronFriel AaronFriel assigned aq17 and unassigned AaronFriel Aug 15, 2022
@AaronFriel AaronFriel mentioned this issue Aug 15, 2022
Closed
43 tasks
@aq17 aq17 mentioned this issue Aug 16, 2022
Merged
3 tasks
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 19, 2022
This was referenced Sep 1, 2022
Merged
Merged
Merged
Open
Merged
Open
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@renovate renovate bot mentioned this issue Sep 9, 2022
Merged
1 task
@renovate renovate bot mentioned this issue Sep 9, 2022
Merged
1 task
This was referenced Sep 24, 2022
Merged
Open
Open
Open
Open
Open
This was referenced Nov 20, 2022
Open
Merged
@renovate renovate bot mentioned this issue Dec 20, 2022
Closed
1 task
This was referenced Mar 15, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aq17 aq17

Labels
area/codegen SDK-gen, program-gen, convert kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.77
Development

Successfully merging a pull request may close this issue.

Fix StackReference code gen pulumi/pulumi
5 participants
@AaronFriel @Frassle @mikhailshilkov @pulumi-bot @aq17