Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the GitHub app to post PR comments rather than PR reviews #74

Closed
henworth opened this issue Jun 24, 2022 · 2 comments
Closed

Allow the GitHub app to post PR comments rather than PR reviews #74

henworth opened this issue Jun 24, 2022 · 2 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed
Milestone

Comments

@henworth
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We recently started using the app and one thing that has come up the most so far is how PR comments are implemented. I know there has been a lot of discussion regarding the ability to remove stale comments, but what I鈥檇 like to get some insight on is why they are implemented as review comments and not just normal PR comments. I would also welcome a configurable option to control the type of comment (review or regular), as this would at least give the ability to delete comments.

I initially brought this up here in the community slack.

Affected area/feature

GitHub App

@henworth henworth added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jun 24, 2022
@blampe
Copy link

blampe commented Jun 30, 2022

This is an extremely reasonable request. I don't think there's a strong reason for these to be review comments.

@EvanBoyle EvanBoyle removed the needs-triage Needs attention from the triage team label Jul 1, 2022
@EvanBoyle EvanBoyle added this to the 0.75 milestone Jul 6, 2022
@blampe blampe closed this as completed Jul 13, 2022
@blampe
Copy link

blampe commented Jul 14, 2022

@henworth this change is now live, thanks for the great suggestion. Keep them coming :)

I know there has been a lot of discussion regarding the ability to remove stale comments

Stay tuned - I'm planning some additional work to hide these automatically. My hope is this ability to manually hide/delete unwanted comments can act as stopgap until that's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed
Projects
None yet
Development

No branches or pull requests

4 participants