Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-provider does not update the TF Plugin SDK replace in ./examples/go.mod #142

Open
iwahbe opened this issue Sep 13, 2023 · 2 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@iwahbe
Copy link
Member

iwahbe commented Sep 13, 2023

What happened?

This causes cd examples && go test ./... to fail:

Expected Behavior

An upgrade of a working provider produces a working provider.

This means that if ./examples depends on ./provider and we update a replace in ./provider, then we need to also update ./examples.

Steps to reproduce

See "What happened"

Output of pulumi about

NA

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@guineveresaenger
Copy link
Contributor

@iwahbe was this fixed in #141 ?

@iwahbe
Copy link
Member Author

iwahbe commented Sep 19, 2023

It doesn't look like it. #141 makes sure that we run the upgrader, but doesn't change where it is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants