Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_io (http and file) not compatible with SDK 2.5 #62

Closed
alextekartik opened this issue Jul 11, 2019 · 3 comments
Closed

node_io (http and file) not compatible with SDK 2.5 #62

alextekartik opened this issue Jul 11, 2019 · 3 comments

Comments

@alextekartik
Copy link
Contributor

2.5 has landed on dart dev and some changes (List to Uint8List) breaks the node_io package for openRead, readAsBytes and Http response.

(Ok I just noticed the PR here: #61)
@pulyaevskiy
Copy link
Owner

I merged #61 but there are still issues with File methods.

@tvolkert are we supposed to update openRead and others to UInt8List as well? I read through dart-lang/sdk#36900 but I'm still not sure what's the recommended strategy here.

@pulyaevskiy
Copy link
Owner

I submitted #63 with openRead fix.

@pulyaevskiy
Copy link
Owner

Sorry forgot to update here: this should be fixed in latest release. Closing but feel free to re-open if something is not addressed still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pulyaevskiy @alextekartik