Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify a require path for testhelp to pass the test. #1073

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Sep 2, 2016

This fixes isolated test.

For example.

$ bundle exec ruby -Ilib:. \
  -r 'rubygems' -r 'minitest/autorun' \
  -e 'Dir.glob "./test/test_http10.rb", &method(:require)'
...
1 tests, 11 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
$ bundle exec ruby -Ilib:. \
  -r 'rubygems' -r 'minitest/autorun' \
  -e 'Dir.glob "./test/test_http11.rb", &method(:require)'
/home/jaruga/git/puma/test/test_http11.rb:4:in `require': cannot load such file -- testhelp (LoadError)
  from /home/jaruga/git/puma/test/test_http11.rb:4:in `<top (required)>'
  from -e:1:in `require'
  from -e:1:in `glob'
  from -e:1:in `<main>'

Check testhelp paths in the tests.

$ grep -r testhelp test/
test/test_rack_server.rb:require 'test/testhelp'
test/test_http10.rb:require 'test/testhelp'
test/test_rack_handler.rb:require 'test/testhelp'
test/test_ws.rb:require 'test/testhelp'
test/test_http11.rb:require 'testhelp' <= it is wrong.

Could you merge this?
Thanks.

@evanphx evanphx merged commit a63c12f into puma:master Sep 5, 2016
@junaruga
Copy link
Contributor Author

junaruga commented Sep 5, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants