Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Exception handling for `on_worker_boot` #1551
When an exception is raised in
What's the best way to handle exceptions that should halt the server? How do you actually halt the server in this case?
I'm sorry if this is not the place for this question. I couldn't find a general discussion board.
I've thought about this and I think this is actually a Bad Thing. If any hook (e.g. anything run by run_hooks) raises an exception we should rescue it, log and notify that the hook was not run successfully. Essentially run_hooks should just rescue and log everything.