Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rackup overrides CLI preference for app #2225

Closed
nateberkopec opened this issue Apr 16, 2020 · 2 comments
Closed

Rackup overrides CLI preference for app #2225

nateberkopec opened this issue Apr 16, 2020 · 2 comments

Comments

@nateberkopec
Copy link
Member

@nateberkopec nateberkopec commented Apr 16, 2020

Describe the bug

Puma should always prefer the rackup file specified by the CLI, but if the rackup DSL command is used, it does not.

Related: #1401

Puma config:

Using the test fixtures in the repo:

rackup "test/rackup/hello-env.ru"

To Reproduce

bin/puma -C my_rackup_config.rb test/rackup/hello.ru

...should return a Hello World! response, but runs the hello-env app instead.

@acmh
Copy link
Contributor

@acmh acmh commented Apr 17, 2020

@nateberkopec, can you help me to solve this? I want to do my first contribution to this amazing project that I have been using for the last 3 years! And I want to solidify my knowledge on puma web server.

Thanks for your time!

@nateberkopec
Copy link
Member Author

@nateberkopec nateberkopec commented Apr 20, 2020

Hi @acmh. Look at CONTRIBUTING.md if you haven't already. Glad to have you on board!

  1. Write a test first. Take a look at the tests in the integration files, they're probably the closest. There are probably a few existing tests for config that may help too. Once you have a failing test, you can look at solutions.
  2. Solution: Will probably involve setting the underlying options correctly in either dsl.rb or configuration.rb.
@acmh acmh mentioned this issue Apr 25, 2020
6 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.