Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: two workflows, MRI & non MRI, separate README badges [changelog skip] #2395

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

MSP-Greg
Copy link
Member

Description

Currently two Actions workflows exist, one for with SSL, another without SSL. Note that these could be combined.

But, non MRI jobs are often failing, and we all hate red badges. Also, things like Actions step timeouts, etc may vary between MRI and non-MRI jobs.

PR creates two new workflows that separate jobs into MRI and non-MRI. Adjust README badges as such.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg
Copy link
Member

dentarg commented Sep 30, 2020

I wonder if there's another phrase to use instead of "non MRI" (I can't think of one right now). This came up because I noticed that the filtering over at https://github.com/puma/puma/actions?query=workflow%3AMRI does not work as expected, "MRI" catches both. Oh well :)

@MSP-Greg
Copy link
Member Author

That's why I changed the links. Let me see if a non-breaking space works...

@cjlarose
Copy link
Member

Is there any value in keeping JRuby and TruffleRuby in the same action? Seems like we'd avoid the name "non MRI" by splitting them.

I guess then we'd get more red X's that way, but at least it'd still be easy to tell if MRI tests are passing or not.

@MSP-Greg
Copy link
Member Author

I used 'non_MRI', and filtering etc works. Non-breaking space did not.

@nateberkopec nateberkopec merged commit bb61c7b into puma:master Oct 1, 2020
@MSP-Greg MSP-Greg deleted the actions-badges branch October 1, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants