Fire on_booted after server starts #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -438,6 +438,10 @@ def run | |||
| when "p" | |||
| w.ping!(result.sub(/^\d+/,'').chomp) | |||
| @launcher.events.fire(:ping!, w) | |||
| if !booted && @workers.none? {|worker| worker.last_status.empty?} | |||
There was a problem hiding this comment.
this conditional kind of hurts my head but I don't have a better suggestion
There was a problem hiding this comment.
Extract logic to helper method with clever name?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR slightly changes the timing behavior of the
on_bootedevent, ensuring that the event is only fired after the server is running (that is, afterServer#runhas been called), so server stats are guaranteed to be available when this event fires.In cluster mode, this is when the first stats 'ping' has been received from all worker processes. The timing of the 'ping' has also been updated to send the first one immediately, instead of after
Const::WORKER_CHECK_INTERVAL(default 5) seconds have passed.Fixes #2212.
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.