Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for non MRI CI stablity [changelog skip] #2434

Merged
merged 8 commits into from
Oct 19, 2020

Conversation

MSP-Greg
Copy link
Member

Description

This PR contains various updates to (hopefully) increase the stability of the non MRI CI.

I ran this fourteen times, and only two jobs failed (excepting jruby-head). TruffleRuby failed once in bundle install, and a JRuby job failed once in the manner shown in PR #2432.

Actions changes

  1. Big Sur is available on Actions, added a single job in both MRI & non-MRI workflows.

  2. Set all JRuby jobs to use JDK11. Since the matrix is sparse, changed it to an 'include' only matrix.

Test Changes

  1. `test/helper.rb

    • changed the run method prepended into Minitest::Test. setup and the test method now run in the same Timeout thread.

    • Only run one Timeout.timeout for teardown methods.

  2. TestIntegrationSingle#test_int_refuse appears to be the test that was intermittently locking up the JRuby CI. Now skipped on JRuby.

  3. TestLauncher#test_puma_stats timed out and failed intermittently, but only on jruby-head. It still times out, but often passes on retry.

  4. 'add small sleep after Server#run' is added in three files for JRuby only. Possibly helps with timeout issues. Again, these are intermittent.

5 & 6 are largely jruby-head issues, and since they are intermittent, it's hard to determine a true solution. Or, the last four commits I could remove or squash ('jruby-head band-aids'). I think.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title Updates for non MRI stablity [changelog skip] Updates for non MRI CI stablity [changelog skip] Oct 18, 2020
@nateberkopec
Copy link
Member

Big Sur is available on Actions

Wow TIL, that's great. Good job GitHub!

add small sleep

Obviously not ideal, but I much much prefer a test suite that we can trust over one that's always red. So this is an improvement that we can fix up later.

Feels so good to see that bright green check.

@nateberkopec nateberkopec merged commit c71d149 into puma:master Oct 19, 2020
@MSP-Greg MSP-Greg deleted the java-home branch October 28, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants