Remove accept_nonblock.rb, add test_integration_ssl.rb #2448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
accept_nonblock.rb
has existed since Puma's SSL implementation used Ruby OpenSSL classes and objects. It has since removed those, and only uses the OpenSSL libraries.Remove the file, as it is no longer needed. It loaded
openssl
, and that is also unneeded on MRI Rubies.Add a new 'ssl' test file that starts a Puma server using
IO.popen
, which decouples the CI environment and what it has loaded. The test is run on all platforms.Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.