reactor.rb - register the io, not the client, rename parameters [changelog skip] #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Puma::Client is a container that contains an 'accepted' io, and also has methods for interacting with other Puma objects. Several Puma::Reactor methods take a Client as a parameter, but are currently named 'io. Change to 'client'. 2. NIO has c, ruby, and java implementations. Normally, an io object is expected to be passed to NIO::Selector#register, but currently we are providing a Client. Change to pass the actual Client io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NIO has c, ruby, and java implementations. Normally, an io object is expected to be passed to NIO::Selector#register, but currently we are providing a Client. Change to pass the actual Client io.
NIO::Monitor's have a#valueattribute, and the client is set to that, so changing to an io affects no other code.Puma::Client is a container that contains an 'accepted' io, and also has methods for interacting with other Puma objects. Several Puma::Reactor methods take a Client as a parameter, but are currently named
io. Change toclient.Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.