Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close idle connections immediately on shutdown #2460

Conversation

cjlarose
Copy link
Member

Description

Fixes #2398 by closing connections that have not yet made requests immediately on shutdown.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@cjlarose cjlarose force-pushed the close-idle-connections-immediately-on-shutdown branch from 9741f1b to f869f46 Compare October 27, 2020 06:06
@cjlarose cjlarose force-pushed the close-idle-connections-immediately-on-shutdown branch from f869f46 to 00faded Compare October 27, 2020 06:40
@nateberkopec nateberkopec merged commit 4c2cd28 into puma:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+C takes a long time to quit in 5.0.x
2 participants