Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] plugins: Add note about Heroku plugin sunset [ci skip] #2508

Merged
merged 1 commit into from Dec 9, 2020

Conversation

olleolleolle
Copy link
Contributor

Description

This PR adds a note to the Puma docs that heroku plugin is no longer a current need.

I didn't change more of the text, since the example plugin "heroku" was good at not being a built-in plugin, so the examples were better off keeping it, until a new non-built-in plugin has been added.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

I didn't change more of the text, since the example plugin "heroku" was good at not being a built-in plugin, so the examples were better off keeping it, until a new non-built-in plugin has been added.
@nateberkopec nateberkopec merged commit c13829c into puma:master Dec 9, 2020
@olleolleolle olleolleolle deleted the patch-3 branch December 9, 2020 15:25
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
I didn't change more of the text, since the example plugin "heroku" was good at not being a built-in plugin, so the examples were better off keeping it, until a new non-built-in plugin has been added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants