Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #string method to Puma::NullIO #2520

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Jan 3, 2021

Description

Makes Puma::NullIO more similar to StringIO.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg
Copy link
Member Author

dentarg commented Jan 3, 2021

CI failure looks unrelated, testing a re-run (of all jobs sadly), the failure was:

 48) Failure:
TestIntegrationSingle#test_hot_restart_does_not_drop_connections [D:/a/puma/puma/test/helpers/integration.rb:304]:
      0 unexpected_response
      5 refused
      0 read timeout
     13 reset
    482 success
    468 success after restart
     13 restart count
Expected no refused connections.
Expected: 0
  Actual: 5

407 runs, 994 assertions, 1 failures, 0 errors, 47 skips

------------------------------------------------------------ Debugging Info
TestIntegrationSingle#test_hot_restart_does_not_drop_connections_threads
   restart_count 4, reset 20, success after restart 901
TestIntegrationSingle#test_hot_restart_does_not_drop_connections
   restart_count 13, reset 13, success after restart 467
TestIntegrationSingle#test_hot_restart_does_not_drop_connections
   restart_count 11, reset 11, success after restart 474
TestIntegrationSingle#test_hot_restart_does_not_drop_connections
   restart_count 12, reset 12, success after restart 470
TestIntegrationSingle#test_hot_restart_does_not_drop_connections
   restart_count 13, reset 13, success after restart 468
---------------------------------------------------------------------------

@dentarg
Copy link
Member Author

dentarg commented Jan 3, 2021

**MRI / windows-2019 2.7 (pull_request) ** Successful in 6m

Yay (this was the failing job, didn't make that clear in my earlier comment)

@dentarg
Copy link
Member Author

dentarg commented Jan 3, 2021

MRI / macos-11.0 2.7
This check failed

Thanks GitHub Actions, that's helpful 🤷

@nateberkopec nateberkopec merged commit 3bee538 into puma:master Jan 4, 2021
@dentarg dentarg deleted the null-io-string-method branch January 4, 2021 17:29
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants