Explicitly require rack/common_logger if :Verbose is true #2547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello!
I found an issue where I had to require
'rack'
or more specifically,'rack/common_logger'
when verbose is set to true,:Verbose => true
.Take this example:
This is the exception:
Users shouldn't have to require rack/common_logger on their end so I added a
require "rack/common_logger"
in the block where Verbose is true.Questions:
test_rack_handler.rb
Should I add this change to the changelog /History.md
?Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.