Extra log #2891
Merged
Extra log #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe use |
|
Thank you @MSP-Greg. Great idea! I'll update it. |
MSP-Greg
approved these changes
Jun 2, 2022
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* logging full backtrace * added the exception message to log * Logging the error first; formatting backtrace
snow
pushed a commit
to helloworld1812/puma
that referenced
this pull request
Oct 10, 2022
* logging full backtrace * added the exception message to log * Logging the error first; formatting backtrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the worker fails to load, it currently logs only the first item from the backtrace, without the error message itself. This makes it very difficult to know exactly what the problem was.
This change logs the entire backtrace + the error message
see #2843 (comment)
Your checklist for this pull request
(before I go further with tests etc, which might be difficult for me as I'm not familiar with the codebase, I'd like to check that the project team is open to accept/adopt this change)
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.