Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update 5-6-stable CI, two backports #3167

Merged
merged 4 commits into from May 29, 2023

Conversation

MSP-Greg
Copy link
Member

Description

See commit comments.

Takes quite a while to run, but we won't be running that often, and there are a lot of Ruby versions.

The time is due to all the macos jobs. Not sure if macos is used much in production, but I'm sure it's used in development. I set the CI matrix up so no Ruby version is run on all three macos versions (11,12,13).

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Adjust Actions Ruby versions
Adjust Actions OS platforms
Don't load RuboCop for CI test runs
Allow testing with Rack v1
Allow failure for all TruffleRuby jobs
@MSP-Greg MSP-Greg mentioned this pull request May 29, 2023
7 tasks
@MSP-Greg MSP-Greg merged commit 0892558 into puma:5-6-stable May 29, 2023
54 checks passed
@MSP-Greg MSP-Greg deleted the 00-5-6-backports branch May 29, 2023 17:53
MSP-Greg added a commit that referenced this pull request May 29, 2023
* Update tests.yaml, Gemfile

  Adjust Actions Ruby versions
  Adjust Actions OS platforms
  Don't load RuboCop for CI test runs
  Allow testing with Rack v1
  Allow failure for all TruffleRuby jobs

* Rakefile - guard loading RuboCop

* Backport 7b63010 No Windows UNIXSocket tests for now

* Backport f323d12 test_integration_single.rb - fix curl msg regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant