Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require puma/dsl not on the top #3287

Closed
SeifESlimene opened this issue Dec 10, 2023 · 2 comments · Fixed by #3288
Closed

require puma/dsl not on the top #3287

SeifESlimene opened this issue Dec 10, 2023 · 2 comments · Fixed by #3288

Comments

@SeifESlimene
Copy link

in source file puma/configuration.rb:

  @user_dsl    = DSL.new(@options.user_options, self)
  @file_dsl    = DSL.new(@options.file_options, self)
  @default_dsl = DSL.new(@options.default_options, self)

I don't understand how instanciate a DSL class where there is no require 'puma/dsl' on the top where it should be in order to use "DSL" inside the code!

Can someone explain to me how that this works the way it works?

@dentarg
Copy link
Member

dentarg commented Dec 10, 2023

There's a comment

# note that dsl is loaded at end of file, requires ConfigDefault constants

@MSP-Greg
Copy link
Member

I'll remove/fix that. See issue #2922, which led to PR #2928, which made the EOF require unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants