Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor | Constantize worker pipe request types #3318

Merged
merged 1 commit into from Jan 15, 2024
Merged

Refactor | Constantize worker pipe request types #3318

merged 1 commit into from Jan 15, 2024

Conversation

joshuay03
Copy link
Contributor

Description

Actioning this comment.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@joshuay03 joshuay03 mentioned this pull request Jan 13, 2024
Merged
7 tasks
dentarg
dentarg reviewed Jan 15, 2024
View reviewed changes
lib/puma/cluster.rb Outdated Show resolved Hide resolved
dentarg
dentarg reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like this 👍 Just had one comment

@dentarg dentarg added the waiting-for-changes Waiting on changes from the requestor label Jan 15, 2024
@joshuay03 @BrandonDefachelleClouet
Refactor | Constantize worker pipe request types
3d82649 
Co-authored-by: Brandon Defachelle Clouet <brandon.defachelle-ext@combohr.com>
@joshuay03 joshuay03 force-pushed the refactor-cluster-pipe-req-cases branch from 513e57f to 3d82649 Compare January 15, 2024 00:14
@dentarg dentarg removed the waiting-for-changes Waiting on changes from the requestor label Jan 15, 2024
@dentarg dentarg merged commit f6ab4e9 into puma:master Jan 15, 2024
68 of 71 checks passed
@joshuay03
Copy link
Contributor Author

Thanks! @dentarg

@joshuay03 joshuay03 deleted the refactor-cluster-pipe-req-cases branch January 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuay03 @dentarg